Commit graph

12 commits

Author SHA1 Message Date
James Paterni
d68e676de3 Enhance dashboard with next backup time, reorganized layout, and pagination
Some checks failed
Test and Build Docker Image / test (push) Has been cancelled
Test and Build Docker Image / build (push) Has been cancelled
## Dashboard Improvements

### 1. Add Time to Next Backup Display
- Add new `/next-backup` endpoint with cron schedule parsing
- Display time until next backup in human-readable format (e.g., "16 hours")
- Show formatted next backup time (e.g., "07:00am")
- Add next backup info to System Health card with schedule details
- Include format_time_until helper for readable time formatting

### 2. Reorganize Dashboard Layout
- Move "Discovered Containers" section above "Recent Backups"
- Improve workflow by showing monitored containers before backup history
- Better logical flow for users checking system status

### 3. Add Pagination to Recent Backups
- Implement client-side pagination with 10 backups per page
- Add pagination controls with Previous/Next buttons and page info
- Show "Page X of Y" information when multiple pages exist
- Hide pagination when 10 or fewer backups exist
- Maintain all existing backup display functionality

### 4. Load Historical Backups on Startup
- BackupMonitor now scans existing .meta files on initialization
- Loads historical backup data from metadata files into backup history
- Estimates duration for historical backups based on file size
- Maintains chronological order and 1000-record memory limit
- Dashboard now shows complete backup history immediately

### Technical Changes
- Add loadNextBackupTime() function with auto-refresh
- Implement displayBackupsPage() with pagination logic
- Add CSS classes for pagination styling
- Update refreshAll() to include next backup time
- Remove duplicate loadRecentBackups functions
- Add proper error handling for all new endpoints

Dashboard now provides comprehensive backup monitoring with improved
user experience and complete historical data visibility.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-15 10:31:09 -04:00
James Paterni
1fa85dac55 Fix container running state detection for different Docker API versions
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
- Handle both string and hash formats for container.info['State']
- Add fallback to container.json['State'] when needed
- Fix "Container not running" error when containers are actually running
- Support multiple Docker API response formats

The Docker API gem can return State as either:
- A simple string: "running"
- A hash: {"Status": "running", "Running": true, ...}

This fix ensures compatibility with different Docker daemon versions
and API response formats.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-15 08:18:46 -04:00
James Paterni
0babc03430 Fix method visibility in BackupMonitor for health check endpoints
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
- Move get_recent_backups, get_failed_backups, and get_container_backup_history methods to public section
- Remove duplicate methods that were incorrectly placed in private section
- Health check server endpoints now fully functional

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-14 23:22:16 -04:00
James Paterni
6688145ff2 Add missing BackupMonitor methods for health check endpoints
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
- Add get_recent_backups method to return recent backup history
- Add get_failed_backups method to return failed backup history
- Add get_container_backup_history method for container-specific history
- All methods are thread-safe with mutex synchronization
- Methods return data in reverse chronological order (newest first)

This fixes the 'undefined method get_recent_backups' error in health endpoints.
2025-07-14 23:16:17 -04:00
James Paterni
a68196431f Fix health check server by using Puma with Rack directly
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
- Replace Sinatra run! calls with direct Puma::Server usage
- Use Rack-compatible approach to avoid Sinatra::Wrapper issues
- Remove problematic set method calls and run! method calls
- Both integrated and standalone health servers now use same Puma/Rack approach
- Remove outdated baktainer/logger require from main file

This should resolve the undefined method errors with Sinatra::Wrapper.
2025-07-14 23:15:26 -04:00
James Paterni
cbde87e2ef Major architectural overhaul: dependency injection, monitoring, and operational improvements
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
This commit represents a comprehensive refactoring and enhancement of Baktainer:

## Core Architecture Improvements
- Implemented comprehensive dependency injection system with DependencyContainer
- Fixed critical singleton instantiation bug that was returning Procs instead of service instances
- Replaced problematic Concurrent::FixedThreadPool with custom SimpleThreadPool implementation
- Achieved 100% test pass rate (121 examples, 0 failures) after fixing 30+ failing tests

## New Features Implemented

### 1. Backup Rotation & Cleanup (BackupRotation)
- Configurable retention policies by age, count, and disk space
- Automatic cleanup with comprehensive statistics tracking
- Empty directory cleanup and space monitoring

### 2. Backup Encryption (BackupEncryption)
- AES-256-CBC and AES-256-GCM encryption support
- Key derivation from passphrases or direct key input
- Encrypted backup metadata storage

### 3. Operational Monitoring Suite
- **Health Check Server**: HTTP endpoints for monitoring (/health, /status, /metrics)
- **Web Dashboard**: Real-time monitoring dashboard with auto-refresh
- **Prometheus Metrics**: Integration with monitoring systems
- **Backup Monitor**: Comprehensive metrics tracking and performance alerts

### 4. Advanced Label Validation (LabelValidator)
- Schema-based validation for all 12+ Docker labels
- Engine-specific validation rules
- Helpful error messages and warnings
- Example generation for each database engine

### 5. Multi-Channel Notifications (NotificationSystem)
- Support for Slack, Discord, Teams, webhooks, and log notifications
- Event-based notifications for backups, failures, warnings, and health issues
- Configurable notification thresholds

## Code Organization Improvements
- Extracted responsibilities into focused classes:
  - ContainerValidator: Container validation logic
  - BackupOrchestrator: Backup workflow orchestration
  - FileSystemOperations: File I/O with comprehensive error handling
  - Configuration: Centralized environment variable management
  - BackupStrategy/Factory: Strategy pattern for database engines

## Testing Infrastructure
- Added comprehensive unit and integration tests
- Fixed timing-dependent test failures
- Added RSpec coverage reporting (94.94% coverage)
- Created test factories and fixtures

## Breaking Changes
- Container class constructor now requires dependency injection
- BackupCommand methods now use keyword arguments
- Thread pool implementation changed from Concurrent to SimpleThreadPool

## Configuration
New environment variables:
- BT_HEALTH_SERVER_ENABLED: Enable health check server
- BT_HEALTH_PORT/BT_HEALTH_BIND: Health server configuration
- BT_NOTIFICATION_CHANNELS: Comma-separated notification channels
- BT_ENCRYPTION_ENABLED/BT_ENCRYPTION_KEY: Backup encryption
- BT_RETENTION_DAYS/COUNT: Backup retention policies

This refactoring improves maintainability, testability, and adds enterprise-grade monitoring and operational features while maintaining backward compatibility for basic usage.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-14 22:58:26 -04:00
James Paterni
d14b8a2e76 Implement comprehensive security fixes and enhancements
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
CRITICAL Security Fixes:
- Add command injection protection with whitelist validation
- Implement robust SSL/TLS certificate handling and validation
- Add backup verification with SHA256 checksums and content validation
- Implement atomic backup operations with proper cleanup
- Create comprehensive security documentation

Security Improvements:
- Enhanced backup_command.rb with command sanitization and whitelisting
- Added SSL certificate expiration checks and key matching validation
- Implemented atomic file operations to prevent backup corruption
- Added backup metadata storage for integrity tracking
- Created SECURITY.md with Docker socket security guidance

Testing Updates:
- Added comprehensive security tests for command injection prevention
- Updated SSL tests with proper certificate validation
- Enhanced PostgreSQL alias method test coverage (100% coverage achieved)
- Maintained 94.94% overall line coverage

Documentation Updates:
- Updated README.md with security warnings and test coverage information
- Updated TODO.md marking all critical security items as completed
- Enhanced TESTING.md and CLAUDE.md with current coverage metrics
- Added comprehensive SECURITY.md with deployment best practices

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-14 10:19:18 -04:00
James Paterni
67bea93bb2 Fix timestamp-dependent test failures by using dynamic patterns
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
- Replace hardcoded timestamps with regex patterns in integration tests
- Use dynamic file discovery instead of exact filenames in unit tests
- Change timestamp pattern from specific values to \d{10} regex for 10-digit unix timestamps
- Update backup file assertions to use Dir.glob and pattern matching
- Ensure tests are robust across different execution environments and times

This resolves intermittent test failures caused by timestamp variations
between test runs and different execution contexts.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-13 23:19:12 -04:00
James Paterni
8db5004eea Add comprehensive RSpec testing infrastructure and enhance CI/CD pipeline
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
- Implement complete test suite with 63 examples (49 unit + 14 integration tests)
- Add RSpec, FactoryBot, WebMock, and SimpleCov testing dependencies
- Create mocked integration tests eliminating need for real Docker containers
- Fix SQLite method signature to accept login/password parameters
- Enhance container discovery to handle nil labels gracefully
- Add test coverage reporting and JUnit XML output for CI
- Update GitHub Actions workflow to run tests before Docker builds
- Add Ruby 3.3 setup with gem caching for faster CI execution
- Create CI test script and comprehensive testing documentation
- Ensure Docker builds only proceed when all tests pass

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-13 23:12:59 -04:00
James Paterni
db946bc26e Project now functions.
TODO:
  - Add individual hook for completed backups
  - Add hook for fullly completed backups
  - Optionally limit time for each backup
2025-05-08 22:41:50 -04:00
James Paterni
c9ba136df5 Use Cron for backup sleep/backuptime. Default log level to info 2025-04-14 09:53:31 -04:00
James Paterni
8430ff9304 Initial Commit 2025-04-14 09:39:37 -04:00