baktainer/app/spec/unit/backup_command_spec.rb
James Paterni d14b8a2e76
Some checks are pending
Test and Build Docker Image / test (push) Waiting to run
Test and Build Docker Image / build (push) Blocked by required conditions
Implement comprehensive security fixes and enhancements
CRITICAL Security Fixes:
- Add command injection protection with whitelist validation
- Implement robust SSL/TLS certificate handling and validation
- Add backup verification with SHA256 checksums and content validation
- Implement atomic backup operations with proper cleanup
- Create comprehensive security documentation

Security Improvements:
- Enhanced backup_command.rb with command sanitization and whitelisting
- Added SSL certificate expiration checks and key matching validation
- Implemented atomic file operations to prevent backup corruption
- Added backup metadata storage for integrity tracking
- Created SECURITY.md with Docker socket security guidance

Testing Updates:
- Added comprehensive security tests for command injection prevention
- Updated SSL tests with proper certificate validation
- Enhanced PostgreSQL alias method test coverage (100% coverage achieved)
- Maintained 94.94% overall line coverage

Documentation Updates:
- Updated README.md with security warnings and test coverage information
- Updated TODO.md marking all critical security items as completed
- Enhanced TESTING.md and CLAUDE.md with current coverage metrics
- Added comprehensive SECURITY.md with deployment best practices

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-14 10:19:18 -04:00

167 lines
No EOL
5.4 KiB
Ruby

# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Baktainer::BackupCommand do
let(:backup_command) { described_class.new }
describe '#mysql' do
it 'generates correct mysqldump command' do
result = backup_command.mysql(login: 'user', password: 'pass', database: 'testdb')
expect(result).to be_a(Hash)
expect(result[:env]).to eq([])
expect(result[:cmd]).to eq(['mysqldump', '-u', 'user', '-ppass', 'testdb'])
end
it 'handles nil parameters' do
expect {
backup_command.mysql(login: nil, password: nil, database: nil)
}.not_to raise_error
end
end
describe '#mariadb' do
it 'generates correct mysqldump command for MariaDB' do
result = backup_command.mariadb(login: 'user', password: 'pass', database: 'testdb')
expect(result).to be_a(Hash)
expect(result[:env]).to eq([])
expect(result[:cmd]).to eq(['mysqldump', '-u', 'user', '-ppass', 'testdb'])
end
end
describe '#postgres' do
it 'generates correct pg_dump command' do
result = backup_command.postgres(login: 'user', password: 'pass', database: 'testdb')
expect(result).to be_a(Hash)
expect(result[:env]).to eq(['PGPASSWORD=pass'])
expect(result[:cmd]).to eq(['pg_dump', '-U', 'user', '-d', 'testdb'])
end
it 'generates correct pg_dumpall command when all is true' do
result = backup_command.postgres(login: 'user', password: 'pass', database: 'testdb', all: true)
expect(result[:env]).to eq(['PGPASSWORD=pass'])
expect(result[:cmd]).to eq(['pg_dumpall', '-U', 'user'])
end
end
describe '#postgres_all' do
it 'calls postgres with all: true' do
expect(backup_command).to receive(:postgres).with(
login: 'postgres',
password: 'pass',
database: 'testdb',
all: true
)
backup_command.postgres_all(login: 'postgres', password: 'pass', database: 'testdb')
end
end
describe '#postgresql' do
it 'is an alias for postgres' do
result = backup_command.postgresql(login: 'user', password: 'pass', database: 'testdb')
expect(result).to be_a(Hash)
expect(result[:env]).to eq(['PGPASSWORD=pass'])
expect(result[:cmd]).to eq(['pg_dump', '-U', 'user', '-d', 'testdb'])
end
it 'forwards all arguments to postgres method' do
result = backup_command.postgresql(login: 'admin', password: 'secret', database: 'proddb', all: true)
expect(result[:env]).to eq(['PGPASSWORD=secret'])
expect(result[:cmd]).to eq(['pg_dumpall', '-U', 'admin'])
end
end
describe '#postgresql_all' do
it 'is an alias for postgres_all' do
result = backup_command.postgresql_all(login: 'postgres', password: 'pass', database: 'testdb')
expect(result).to be_a(Hash)
expect(result[:env]).to eq(['PGPASSWORD=pass'])
expect(result[:cmd]).to eq(['pg_dumpall', '-U', 'postgres'])
end
end
describe '#sqlite' do
it 'generates correct sqlite3 command' do
result = backup_command.sqlite(database: '/path/to/test.db')
expect(result).to be_a(Hash)
expect(result[:env]).to eq([])
expect(result[:cmd]).to eq(['sqlite3', '/path/to/test.db', '.dump'])
end
it 'handles missing database parameter' do
result = backup_command.sqlite(database: nil)
expect(result[:cmd]).to eq(['sqlite3', nil, '.dump'])
end
end
describe '#custom' do
it 'splits custom command string' do
result = backup_command.custom(command: 'pg_dump -U user testdb')
expect(result).to be_a(Hash)
expect(result[:env]).to eq([])
expect(result[:cmd]).to eq(['pg_dump', '-U', 'user', 'testdb'])
end
it 'handles nil command' do
expect {
backup_command.custom(command: nil)
}.to raise_error(ArgumentError, "Command cannot be nil")
end
it 'handles empty command' do
expect {
backup_command.custom(command: '')
}.to raise_error(ArgumentError, "Command cannot be empty")
end
it 'handles commands with multiple spaces' do
result = backup_command.custom(command: 'pg_dump -U user testdb')
expect(result[:cmd]).to eq(['pg_dump', '-U', 'user', 'testdb'])
end
describe 'security protections' do
it 'rejects commands not in whitelist' do
expect {
backup_command.custom(command: 'rm -rf /')
}.to raise_error(SecurityError, /Command 'rm' is not allowed/)
end
it 'removes dangerous shell characters' do
result = backup_command.custom(command: 'pg_dump -U user; echo "hacked"')
expect(result[:cmd]).to eq(['pg_dump', '-U', 'user', 'echo', '"hacked"'])
end
it 'rejects commands with suspicious arguments' do
expect {
backup_command.custom(command: 'pg_dump -U user /etc/passwd')
}.to raise_error(SecurityError, /Potentially dangerous argument detected/)
end
it 'rejects commands with directory traversal' do
expect {
backup_command.custom(command: 'pg_dump -U user ../../../etc/passwd')
}.to raise_error(SecurityError, /Potentially dangerous argument detected/)
end
it 'allows valid backup commands' do
%w[mysqldump pg_dump pg_dumpall sqlite3 mongodump].each do |cmd|
result = backup_command.custom(command: "#{cmd} -h localhost testdb")
expect(result[:cmd][0]).to eq(cmd)
end
end
end
end
end